Add multi-stage logic to docker to slim down images #286
+348
−180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Rockylinux image was failing in CI due to being too big: https://github.com/Rust-GPU/rust-cuda/actions/runs/18154387364/job/51766584764. Other ones can have similar problem. |
LegNeato
force-pushed
the
docker
branch
4 times, most recently
from
c6a01f3 to
7919505
Compare
This was referenced Nov 13, 2025
LegNeato
force-pushed
the
docker
branch
6 times, most recently
from
70f2b64 to
9647832
Compare
And remove the rust cache as it likely is not helping
LegNeato
force-pushed
the
docker
branch
2 times, most recently
from
c708871 to
5d0edab
Compare
We need to delete stuff on the host. If we use the built-in support, our job starts in the docker container and we can't clean up stuff to make space on the host volume.
And delete incremental files. Without this uploading artifacts fails with permission issues.
nnethercote
reviewed
Nov 21, 2025
This was failing on rocky linux because I think it was pulling the wrong artifact. The tests don't do anything so this isn't strictly needed.
These tests are stubbed out / don't do anything and I can't figure out why Rocky is failing downloading GH artifacts. So disable it for now
Contributor
Author
|
Oh thank god. |
Collaborator
|
🎉 |
Collaborator
|
There is a second RockyLinux mention in |
Contributor
Author
|
Yeah, it is fixed! It is a bit weird due to only pushing the image on main that PR tests use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.